etherpad-lite icon indicating copy to clipboard operation
etherpad-lite copied to clipboard

Doing Ctrl-B, then typing, doesn't result in bold text, despite ep_sticky_attributes

Open paulproteus opened this issue 7 years ago • 2 comments

Steps to reproduce:

  • Create a new Etherpad grain, e.g. on demo.sandstorm.io in an incognito window.

  • Press Ctrl-B on one's keyboard (or persumably Option-B on a mac?).

  • Type some text.

Expected behavior:

  • The new text is written-out as bold.

Actual behavior:

  • The new text isn't bold, but instead is in the default style.

Implementation notes:

  • Per https://github.com/ether/etherpad-lite/issues/447 , the ep_sticky_attributes plugin should enable this behavior. However, per the default grain text, that plugin is enabled in Etherpad on Sandstorm. Therefore, I'm not quite sure what to suggest here except possibly tracing how keyboard events are handled in the case of Ctrl-B.

paulproteus avatar Nov 29 '16 22:11 paulproteus

This works correctly for me. Here's what I did:

  1. Open Google Chrome on Linux.
  2. Open an incognito window.
  3. Visit etherpad.org.
  4. Click "try a demo".
  5. Click "try etherpad".
  6. Once loaded, press ctrl+b.
  7. Type.

I received the expected result: The text I typed was bold.

Can you please clarify what you did differently?

kentonv avatar Dec 05 '16 03:12 kentonv

Similar behavior (italicize behaves same). Sent following to Sandstorm people last week:

Bold and italic shortcuts don't toggle without selection. I enter Command-b or Command-i (I assume ^b or ^i in Windows) with a null selection just the insertion point anywhere, and it doesn't toggle into/out of bold or italic respectively as I continue typing.

pzelchenko avatar Dec 05 '16 06:12 pzelchenko