Kent C. Dodds

Results 890 comments of Kent C. Dodds

I'm good with that solution is someone wants to make a pull request.

Thanks for this! Is this a breaking change?

Bummer, looks like this project is using old versions of deps and something broke. I'm afraid I don't have any time to get things updated in this project and get...

Whatever you two want to do. I don't use babel anymore.

@fatfisz made a pull request to workaround this issue in babel-plugin-macros: https://github.com/kentcdodds/babel-plugin-macros/pull/64 Would be cool to remove that workaround one day ๐Ÿค—

I think this has been a long-standing problem honestly. Ever since we started server rendering React we've had a file that could run in two different JS environments ๐Ÿคทโ€โ™‚๏ธ

Yup, definitely looks like we're bumping up against the limits of TypeScript here ๐Ÿ˜… I guess so far we've all just been fine with TypeScript not being able to catch...

I'd rather use http://npm.im/debug It's a pretty standard tool for this kind of thing. I think our debug key could be simply `babel-plugin-tester`. Would you be willing to try that?

That sounds reasonable to me ๐Ÿ‘ I'd be willing to accept a pull request for this.