auto-assign icon indicating copy to clipboard operation
auto-assign copied to clipboard

Published 20 hours ago • verified publisher icon kentaro-m

Can I use auto-assign bot with Github teams?

Open mrlubos opened this issue 5 years ago • 13 comments

Hi! I am just exploring the auto-assign bot and I see I can configure groups to assign for reviews. However, these have to be defined in the config file. Since we already manage our groups in Github teams, would it be possible to reference only the Github team names in the config? Or is this an already existing feature? Thanks!

mrlubos avatar Sep 05 '19 12:09 mrlubos

Hi, @mrlubos! Thanks for waiting. The auto-assign bot is not supported to assign reviewers to the pull request using GitHub teams now. This topic has been discussed in https://github.com/kentaro-m/auto-assign/issues/39 and https://github.com/kentaro-m/auto-assign/issues/71.

Currently, It is hard to spend time on improving this tool. I have no plan to implement the feature. But improving features by creating the PR is always welcome.

kentaro-m avatar Sep 12 '19 17:09 kentaro-m

Thanks for the reply @kentaro-m!

Is there any recommended workaround? For example, automatically generating the configuration file?

If not, we might look into creating a pull request. Would you have any pointers how to go about implementing this functionality within the auto-assign bot?

Thank you!

mrlubos avatar Sep 12 '19 18:09 mrlubos

+1

This would be a great feature!

okgolove avatar Oct 22 '19 14:10 okgolove

+1

Awesome!

kwangsooshin avatar Oct 25 '19 07:10 kwangsooshin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 24 '19 08:12 stale[bot]

Do not close, please

okgolove avatar Dec 26 '19 18:12 okgolove

Hi everyone! I created a pull request adding this functionality in #120, I would appreciate your feedback!

mrlubos avatar Feb 27 '20 20:02 mrlubos

Are you guys sure whether it's properly working? Because when i try, the log goes okay, but no reviewers are added to the reviewers list on the right side of the PR page.

@mrlubos @kentaro-m

matheusnascgomes avatar Mar 14 '20 02:03 matheusnascgomes

Hey @matheusnascgomes, nice catch! 😃 Yes, it doesn't appear to be working for me either, I will need to look into why that is.

mrlubos avatar Mar 15 '20 20:03 mrlubos

+1

adipatel avatar May 22 '20 07:05 adipatel

I just tried this within our team and it does not work. I tried the @OrgName/team-name and the /team-name syntax in the auto_assign.yml file, neither one added the teams as reviewers. .github/auto_assign.yml:

addReviewers: true

reviewers:
    - /team-a
    - /team-b

numberOfReviewers: 0

We also use a .github/CODEOWNERS file, and it works fine, the owner team is added for review, and their approve is required for the merge.

*	@Org/team-c

igabesz avatar Aug 18 '20 09:08 igabesz

+1

alexandrulesi avatar Sep 01 '20 11:09 alexandrulesi

Any updates on this?

vicsufer avatar Oct 26 '20 14:10 vicsufer