quill-image-drop-module icon indicating copy to clipboard operation
quill-image-drop-module copied to clipboard

[custom-handler] Allow specifying a custom file reader handler

Open kensnyder opened this issue 5 years ago • 4 comments

kensnyder avatar Mar 19 '19 23:03 kensnyder

File reading is not my thing but would this line

const blob = file.getAsFile ? file.getAsFile() : file;

be better served before the fileReader callback is checked for and called? That way we can be semi sure a File is returned in the callback instead of an Item?

stargazing-dino avatar Mar 20 '19 13:03 stargazing-dino

@Nolence Let me update the PR.

kensnyder avatar Mar 20 '19 15:03 kensnyder

@Nolence have a look now.

kensnyder avatar Mar 20 '19 16:03 kensnyder

Is this going to be merged? Doesn't seem to be any issues but it's been almost three months.

zachzoup avatar Jun 14 '19 14:06 zachzoup