popline icon indicating copy to clipboard operation
popline copied to clipboard

isBarOrChild is bugged

Open adantart opened this issue 9 years ago • 5 comments

I don't understand (yet ;-) the "isBarOrChild" but it's the origin of a little bug.

When you select a line (a whole line) with the mouse from left to right, the menu appears. But when you do from the right (the end of line) to the left (beginning of the line), the menu is not showing.

It's because the isTargetOrChild and isBarOrChild are false, so the bar is not showing up.

I don't know how to fix it yet (well, forcing isBarorChild to true, but I guess this is not the solution ;-)

adantart avatar Feb 17 '16 13:02 adantart

@adantart Thanks for reporting, and sorry for my crude naming strategy. Let me check the bug.

kenshin54 avatar Feb 19 '16 09:02 kenshin54

Thank you, by the way, I'm working in a plugin to enable image upload directly with the Google Cloud Storage API (with Javascript). I hope to ask for a pull request soon ;-)

adantart avatar Feb 19 '16 21:02 adantart

Any solution ?

adantart avatar Feb 24 '16 17:02 adantart

Hi,

Commenting out following lines has fixed the above issue. https://github.com/kenshin54/popline/blob/v1.0.0/scripts/jquery.popline.js#L28-L29

But now the tooltip is coming all over the document(wherever the text gets selected) instead of intended container.

is there any workaround?

Thanks, Guruprakash

rguruprakash avatar Jul 22 '16 09:07 rguruprakash

Hi,

I made a small tweak based on this answer in stackoverflow.com to make it work.

https://github.com/rguruprakash/popline/commit/ea65cb4826e78c11dc17080bdb7459b2e9c462f3

Thanks, Guruprakash

rguruprakash avatar Aug 05 '16 07:08 rguruprakash