react-google-login-component Init gapi

Made the changes from https://github.com/kennetpostigo/react-google-login-component/pull/5 and some minor tweaks. I'm wondering if all the options from https://developers.google.com/identity/sign-in/web/reference#gapiauth2clientconfig should be added as props? Maybe add defaultProps and propTypes? @kennetpostigo @darrenchiu what do you think :)

May 04 '17 21:05 D-Andreev

@D-Andreev Did you check these changes against the example project?

May 05 '17 16:05 kennetpostigo

@kennetpostigo Yes, I tested it with the example app, login button works and popup is not blocked.

May 05 '17 17:05 D-Andreev

@D-Andreev i agree that we should add those options as props, but should it be a separate pull requests?

May 06 '17 09:05 darrenchiu

Hey guys sorry im late responding. Currently on vacation but will try to thoroughly review changes ASAP.

May 07 '17 01:05 kennetpostigo

@koss-lebedev do you think you can review these changes here?

Aug 02 '17 17:08 kennetpostigo

Hey @D-Andreev,

thank you for this PR! Can you sync your branch with the current master and re-submit PR with only init-gapi changes? Your current PR includes some unrelated things (.idea project files) and things that we already fixed, like props.children, extraneous wrapping div, etc. I'll be happy to review it after that.

cc: @kennetpostigo

Aug 03 '17 06:08 koss-lebedev

@koss-lebedev I gave you publishing rights to both packages on npm. I've been running a bit behind on publishing to npm. So feel free to review PR's, cc me, and the publish when changes are merged.

Aug 03 '17 14:08 kennetpostigo

Whats the status on this?

Oct 06 '17 02:10 kennetpostigo