responder Potential code quality improvements

I forked this repo and ran a DeepSource analysis over it. There:

12 Antipattern issues were found
4 Bug-Risks issues were found
1 Performance issue was found
31 Security issues were found

Out of which 22 can be auto fixed. Some of them can be found here

https://deepsource.io/gh/pnijhara/responder/issue/PYL-W0611/
https://deepsource.io/gh/pnijhara/responder/issue/PYL-W0613/
https://deepsource.io/gh/pnijhara/responder/issue/BAN-B101/

In all total number of issues are listed here - https://deepsource.io/gh/pnijhara/responder/

Link to .deepsource.toml configuration file that was added to the forked repo for running DeepSource analysis can be found here

Which of these issues you would consider high priority, and which ones would you want to ignore or consider false-positive?

I can send a PR with some fixes if you want. You can also activate this analysis on your own, and have it triggered on each PR if you integrate DeepSource in the repo

Disclaimer: I work for DeepSource

Jun 17 '20 05:06 pnijhara

cc @taoufik07 @ken-reitz What do you think?

Aug 23 '20 21:08 pnijhara

Hey @pnijhara, thanks for this tool ! for now let's just create PRs to fix the potential code quality improvements, the security and bug issues are on high priority.

Aug 24 '20 12:08 taoufik07

Sure! I will open issues for discussion on security and bug-risk issues.

Aug 25 '20 08:08 pnijhara

I'm going to close this, for tracking

Nov 12 '23 13:11 kennethreitz

I can send a PR with some fixes if you want.

that would be great!

Nov 12 '23 13:11 kennethreitz

@kennethreitz do you want me to work on this?

Nov 13 '23 13:11 pnijhara

sure!

Nov 13 '23 13:11 kennethreitz