Connections no longer close prematurely.

[gdtroszak]

This should fix the issue outlined in https://github.com/kennethreitz/records/issues/128. Essentially, SQLAlchemy connections were being closed prior to their results being consumed by RecordCollections.

Connections spawned by Database query methods are configured to automatically close once their results are consumed. Otherwise, just calling db.get_connection() will return a Connection that must be managed by the user. I also made it a point to check for stray connections prior to closing the DB, but that may be overridden.

Sorry for the delay on this.

[techalchemy]

Thanks for handling this, I was just about to start looking at it!

[mostafazh]

Shouldn't this be merged?

[gdtroszak]

I believe so. I just need someone with the appropriate privileges to review and merge.

[kittenswolf]

@vlcinsky

[vlcinsky]

I plan to check it by Monday. Thanks for reminding.

[Projjol-zz]

hey @vlcinsky, is this good to go?

[gdtroszak]

Bueller... Bueller... Buelller...

[chuangbo]

Any updates? @vlcinsky