clint icon indicating copy to clipboard operation
clint copied to clipboard

Purge arguments/args code from clint

Open jackric opened this issue 12 years ago • 9 comments

Following on from ab401e7af2bf892cb96e1bf74de07fccdb1e2a24 arguments/args has been partially pulled out of clint, but there are still references to it.

Since there is the separate module https://github.com/kennethreitz/args the use of clint.args should be deprecated (but still backwards compatible, for a period of time). A corollary of this is that the examples directory should no longer demonstrate the features of the args module (but it's fine to use it in the demonstration of other things, such as in examples/unicode.py

jackric avatar Aug 08 '12 16:08 jackric

The plan is to simply update the included version of args to be up to date.

kennethreitz avatar Aug 08 '12 16:08 kennethreitz

clint now has a dependency on the args module declared in setup.py so why not encourage developers to just use args directly, rather than think of it as part of the clint package?

jackric avatar Aug 08 '12 16:08 jackric

clint is designed to be fully vendorable, and that breaks that.

kennethreitz avatar Aug 08 '12 16:08 kennethreitz

What do you mean by vendorable?

jackric avatar Aug 08 '12 16:08 jackric

I mean that the entire package can be embedded into your application. This is useful for command line applications.

Kenneth Reitz

On Aug 8, 2012, at 12:43 PM, Jack Riches [email protected] wrote:

What do you mean by vendorable?

— Reply to this email directly or view it on GitHub.

kennethreitz avatar Aug 08 '12 20:08 kennethreitz

OK, so if I understood correctly, in the future the dependency on the args package in setup.py will be removed, and instead all the functionality from args will be included inline in the package clint.

Its your project, but I don't think duplicating code is a good idea (2 places to maintain it) - so are you planning to do it with a submodule or something?

jackric avatar Aug 08 '12 21:08 jackric

The answer, from kenneth: https://github.com/kennethreitz-archive/clint/issues/85#issuecomment-12809790

LuRsT avatar Mar 01 '13 15:03 LuRsT

@kennethreitz mentions he'd like to move over to docopt, but this would mean the package would no longer be vendorable - thoughts?

jpiper avatar Jan 09 '14 23:01 jpiper

Ship docopt bundled with clint. Patch console scripts to use bundled version over installed one https://bitbucket.org/techtonik/locally/src/09f9f542795fabca1fc5706b44585cdb304a76d7/01.pure-nodeps.py?at=default

techtonik avatar Jan 09 '14 23:01 techtonik