active_flag icon indicating copy to clipboard operation
active_flag copied to clipboard

Add set_all! and unset_all! for relation scope

Open killondark opened this issue 1 year ago • 1 comments

Hi @kenn. I done realize requested feature. Check please.

killondark avatar Dec 24 '24 13:12 killondark

@kenn, up.

killondark avatar Jan 13 '25 11:01 killondark

was surprised to realize scoped calls to set_all don't respect the scope. any update on getting this merged in and released?

jake avatar Jun 12 '25 19:06 jake

@jake, nope. No updates.

killondark avatar Jun 13 '25 07:06 killondark

Passing scope in as an arg is not good. I'll come up with something when I have time — expect some time in July.

kenn avatar Jun 16 '25 22:06 kenn

Sounds good, thank you! Just wanted to point out that the way it currently works is arguably pretty broken and error-prone. If you call set_all on a scope, it just ignores that scope and applies it globally to the entire table. Not sure if this is any easier than just making it apply the scope, but feels like even throwing an exception if you call it on a scope would be good.

jake avatar Jun 16 '25 22:06 jake