kenjis

Thank you for reporting. But I cannot reproduce. The following test passes. ```php public function testEmailSubjectWithAccentedCharacters(): void { $config = config('Email'); $email = new MockEmail($config); $email->setTo('[email protected]'); $email->setFrom('[email protected]'); $email->setSubject('Email éé Test');...

You cannot use RawSql as the first parameter. See - https://codeigniter4.github.io/CodeIgniter4/database/query_builder.html#join - https://codeigniter4.github.io/CodeIgniter4/database/query_builder.html#query-builder-join-rawsql - https://codeigniter4.github.io/CodeIgniter4/database/query_builder.html#CodeIgniter\Database\BaseBuilder::join I sent a PR to fix the docs #9072. If anyone sends a PR to...

I think these magic properties cannot be written. We cannot write like `$db->DBDriver = 'SQLite3'`, but we can read `$db->DBDriver`. So they should be `@property-read`. > The `@property-read` and `@property-write`...

If they are protected properties, they are not readonly. So the "Cannot modify readonly property ..." message is wrong.

Thank you for sending a small PR. But we don't accept this, because there are breaking changes. We do not accept breaking changes in minor/patch releases. > Only major releases...

Also your one commit has several changes. https://github.com/codeigniter4/CodeIgniter4/pull/9128/commits/9eef920fcec4a3d562e767256a01f0f3c8e15805 includes: - adding `declare()` - adding property types - adding return types - adding parameter types - adding doc comments - using...

I think the following is a way to go. ```diff --- a/system/HTTP/URI.php +++ b/system/HTTP/URI.php @@ -1177,7 +1177,8 @@ class URI implements Stringable parse_str($params, $result); foreach ($result as $key => $value)...

Please fix errors in GitHub Action checks, and add test code. Reference: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

> [!IMPORTANT] > We expect all code changes or bug-fixes to be accompanied by one or more tests > added to our test suite to prove the code works. This...

It seems `bool` is missing in the PHPDoc type.