public_dir cannot be absolute

Open kylekyle opened this issue 9 years ago • 1 comments

If you pass an absolute directory to public_dir, it will be concatenated to the end of __FILE__, for something like this:

/Users/kyle/server/lib/Users/kyle/public

Mar 13 '16 00:03 kylekyle

thanks. yes, it is joined to root - which is lazily inited to app_file/... see the following lines:

https://github.com/kenichi/angelo/blob/master/lib/angelo/base.rb#L54 https://github.com/kenichi/angelo/blob/master/lib/angelo/base.rb#L142-L144 https://github.com/kenichi/angelo/blob/master/lib/angelo/base.rb#L111-L119

you can set it relatively, using ../.. etc. if you think it would be useful to have absolute path support, i would be open to a PR that checks for / at the beginning of the string maybe or something like that.

what are your thoughts?

Mar 15 '16 11:03 kenichi