kendryte-standalone-sdk icon indicating copy to clipboard operation
kendryte-standalone-sdk copied to clipboard

Unify DMA function signatures

Open michprev opened this issue 6 years ago • 0 comments

Please notice different order of arguments in functions that use DMA. It would be nice to unify this I believe. For example (device_num, dmac_send_channel, dmac_receive_channel, send_buf, send_size, recv_buf, recv_size, other...).

It should be decided ASAP as any changes will break existing code.

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/i2c.h#L404-L405

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/i2c.h#L438-L440

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/i2s.h#L654-L655

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/i2s.h#L666

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/spi.h#L275-L277

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/spi.h#L295-L298

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/spi.h#L315-L317

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/spi.h#L335-L338

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/spi.h#L353-L354

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/spi.h#L370-L372

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/spi.h#L397-L400

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/uart.h#L275

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/uart.h#L286

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/uart.h#L301-L303

https://github.com/kendryte/kendryte-standalone-sdk/blob/8c6b3f22910fb22e215b01094fc29af0fb0288f8/lib/drivers/include/uart.h#L317-L319

michprev avatar Jan 11 '19 17:01 michprev