Kendall Bennett

Ok here is a more simplified yaml schema: ``` yaml openapi: 3.0.0 info: title: oneOf bug version: 1.0 components: schemas: request_body: type: object additionalProperties: false oneOf: - $ref: '#/components/schemas/first_id_request' -...

Ok I have fixed the code for my own use, and there is a pull request for it here: https://github.com/RicoSuter/NJsonSchema/pull/1228 The only valid solution to generation of classes in C#...

Names don't get along, no. Using oneOf is nasty IMHO, period. I would never design an API that way myself and if you generated a swagger spec from a set...

To help illustrate the problem, you can look at the worst case scenario in the ShipEngine API here: https://github.com/kendallb/shipengine-openapi/blob/master/openapi.yaml#L5120 and then the actual generated class: https://github.com/kendallb/ShipEngineApi/blob/master/src/ShipEngineApi/IShipEngineClient.generated.cs#L2172 and then the actual...

FWIW, I just tested generation of TypeScript clients for ShipEngine, and with my code changes it produces the correct result and without them, it produces client classes that are not...

Yes I think it is a major issue. If a spec is generated from a strongly typed class structure like C#, then it’s easier to go back the other way....

Well my pull request here https://github.com/RicoSuter/NJsonSchema/pull/1228 already gets it to work correctly for C# code generation, but as I said the unit test break. I don't want to change the...

You might want to try my fork: https://github.com/kendallb/NJsonSchema I fixed the oneOf support so it works, at least for the use case we have (ShipEngine API). I don't think any...

My fork if nswag works for the code generation side. I forget if I have my own nuget package or if I build it all as one project. https://github.com/kendallb/NSwag

Yeah, I changed my IDE to only trim whitespace on the lines I edit now for open source projects for that reason. It used to change every line (nice for...