Ken Cochrane

Results 196 comments of Ken Cochrane

I see. So, depending on the endpoint, they would have a different configuration. How do you propose that we make the settings configurable based on the endpoint?

Ok, that seems like a big change because we would have to move all settings from the top level to a new DEFENDER_CONFIG setting and support both going forward, and...

@omarfateh0, what do you have set for your DEFENDER_REDIS_URL config? Also, which Redis library and version are you using?

In the last release we removed a bunch of custom code to parse redis URLs and replaced it with the one built into the redis library. Probably related, but I'm...

It looks like we still have one of the checks failing before we can merge. Anyone know how to fix it?

@alexmt I think closing this one and adding improvement to `argocd appset create --dry-run` make sense. Thank you

@gnadaban, we have already frozen 0.8.0 and are only accepting critical bug fixes now. The main goal is to get 0.8.0 out the door as stable as possible, and if...

You shouldn’t have to wait 5 weeks to get this merged. If all goes as planned, 0.8.0 goes out the door this week, and then next week we can merge...

@saurav-codes it looks like some of the tests failed, it might require a change to the tox settings. maybe something changed recently.

@saurav-codes The change looks reasonable; if you can get the tests to pass and update the documentation, it should be good to merge. Thanks