Niklas Keller

Results 460 comments of Niklas Keller

Don't see any reason to upgrade.

Can you please include a minimal example of the server code and the whole request sent by the client?

That's a good observation! Would you like to work on a fix and submit a pull request?

> I certainly do not want to have to require PSR-7 and its myriad of other deps PSR-7 is a very simple package without dependencies. What am I missing here?...

Why do they prefer an early open? Anyway, I guess a configuration option makes sense that allows to skip early open?

> This is IMHO a bug, which is due to the usage of `REPLACE_EXISTING` option during the file renaming phase. As I mentioned in [#3021 (comment)](https://github.com/apache/logging-log4j2/pull/3021#issuecomment-2387803826), I plan to modify...

> Ideally we could set the last-modified time to the theoretical time of the rollover, which should be close to the time the file was actually modified. We need to...

@rgoers Do you remember why you changed from modified time to creation time in https://github.com/apache/logging-log4j2/commit/e392c79274ab5cd545d59d7e8fa3b744c7367d16? Calling `file.lastModified()` in `initialFileTime` if the file doesn't exist doesn't seem to make sense. My...