Niklas Keller

Results 460 comments of Niklas Keller

Not yet, maybe there's time for that tomorrow.

Replaced it now, even if the other thing would have worked, it's more concise now. :-)

I just merged master to resolve any conflicts. Didn't rebase to not fuck things up.

Logging would be a good start, but my preferred way would be exposing the size either via the health metrics or via a public API, so I can create my...

Yes, running Java 17.0.10. I've seen the undocumented option, but wasn't sure on the impact it really has. Can this be documented? Especially as `=3` indicates there are multiple different...

> * The APM-server copies the value from `http.request.headers.User-Agent` into `user_agent.original` That's good to know. Currently we have `capture_headers` disabled for the service in question. Does that copy work in...

@maggieghamry @jackshirazi There's a workaround, see https://gist.github.com/kelunik/c3971068a7d1a1f0acd7c2143028ce1b, which is also linked in the above linked original discussion.

I can do that, but probably rather in two weeks than next week. Could you open a PR for the review?

Indeed, e.g. I've removed a probably malicious download link here: https://github.com/square/retrofit/wiki/Home/_compare/4a0aca53c58e56018bd2f0c5607f74878affee13...8d5a4affcfd150fa06ba9799fb18b1a78cc8f580

No, counters are fine, but metrics should be recorded when bytes are sent / received instead of on connection closure.