acme-client icon indicating copy to clipboard operation
acme-client copied to clipboard

Display real errors for failed challenges

Open Globulopolis opened this issue 7 years ago • 3 comments

Hi! I've found this https://github.com/kelunik/acme-client/blob/master/src/Commands/Issue.php#L101-L107 in code. Maybe it's better to throw an real exception message instead of Issuance failed, not all challenges could be solved. ? Because in current implementation foreach is useless.

Globulopolis avatar Feb 24 '17 06:02 Globulopolis

The current implementation shows the error messages to the console, why is that useless? Could you clarify?

kelunik avatar Apr 15 '18 17:04 kelunik

I meant an extended error description. Not a predefined value.

Globulopolis avatar Apr 16 '18 07:04 Globulopolis

@Globulopolis The foreach about the previous errors should give more information. We could merge them into the exception message, but the information that's given to the end-user will be almost the same.

kelunik avatar Apr 16 '18 08:04 kelunik