Kelson

Results 4085 comments of Kelson

> Does this mean re-running the filename mime type detecting (regex based on path) at the time that we are downloading the image/converting to webp, and refusing to do the...

@benoit74 Thank you for the analysis, in this specific case, I would like that we consider to build a workaround for the time being. Is that reasonably feasible?

@sanks011 Yes "hbs" should be OK, but actually we should maybe fix problem upstream at Wikipedia level? I will ping someone.

@ShaopengLin The feature work well to my opinion, but we need to change/polish the way how the TOC is displayed, [see my comment in the issue](https://github.com/kiwix/kiwix-desktop/issues/42#issuecomment-2337479230). On the top: *...

> @kelson42 To clarify, what does the view entry do? I didn't see it from the mockup, but I assume you mean either a button to collapse the entire TOC,...

@ShaopengLin Sorry, I don't get it, shortcut does not display the TOC sidebar AND no icon in the toolbar ![image](https://github.com/user-attachments/assets/1094c4d3-8665-4b78-aa78-dc887621c18d)

> Do you mean to highlight the items in the TOC when we hover them? Not sure what "full background" means here. I believe you understand properly. Item background highlighted...

Lots of things work fine, but: * TOC toolbar button is not always activated properly, here just after opening a ZIM file from the local library! I don't believe you...

@ShaopengLin Not all points: On the following screenshot you clear see: * The width of the sidebar is even bigger than before and not the same as the bookmarking one...

> @kelson42 Fix size done. > > > Top margin over "highlighed" text is bigger than left > > This isn't intentional. If you highlight any text, that's just how...