Kelson

Results 4116 comments of Kelson

Modulo the remarks done earlier, this first version of the new `/widget` feature looks good to me. Adding @veloman-yunkan for the code review

@juuz0 Please create a dedicated ticket + PR for selecting ZIM files based on there ZIM `Name` metadata. It should work in general and not only for the widget.

@juuz0 Any feedback?

@mgautierfr Considering that this is a function which is really necessary for Kiwix Android but not only (we should have the same check on Kiwix Desktop for example), I'm really...

@macgills @mgautierfr We should carry on this before 3.0 release. It is simpy not acceptable to have users waiting for one minute to know if a fs can support file...

@macgills Thank you for the update. This makes the whole topic a bit less urgent, but considering that @mgautierfr won't be available for a few months. I'm concerned if we...

Hmm.. not really, because the problem is not only with Android, it is everywhere.We have still not good solution for other ports.

@MohitMaliDeveloper Does not sound a proper fix to me? Why `?` should be special handled? Which garanty that we don't need that somewhere else?

You probably solved it, but to me putting a special handling like this is a middle of nowhere is a sign that something more fundamental goes wrong. This is why...

> url return from webview and url return from zimReaderContainer are different Yes, but how exactly and why? AFAIK the URL in the ZIM are not URL encoded, whereas the...