CocoaSecurity
CocoaSecurity copied to clipboard
Remove #import "Base64.h"
As noted in https://github.com/nicklockwood/Base64 readme.
"In the iOS 7 and Mac OS 10.9 SDKs, Apple introduced new base64 methods on NSData that make it unnecessary to use a 3rd party base 64 decoding library. What's more, they exposed access to private base64 methods that are retrospectively available back as far as IOS 4 and Mac OS 6."
I wanted to fork and submit a PR. But in NSData base64 encoding, there is this NSDataBase64EncodingOptions
parameter that I'm not sure which one I should use. So I created this issue instead.
https://developer.apple.com/library/ios/documentation/cocoa/reference/foundation/classes/NSData_Class/Reference/Reference.html#//apple_ref/doc/c_ref/NSDataBase64EncodingOptions
Thanks for raising this issue @hlung. I have fixed this in my fork and opened a pull request. I just passed in 0 for NSDataBase64EncodingOptions
and that seemed to work. I had to make a small change to return nil if an empty string is passed in, but now all tests are passing.
@timrossinfo looks like this was also submitted as a change by @Whirlwind (https://github.com/kelp404/CocoaSecurity/pull/14), but his pull request is failing. Did you submit a pull request for your changes?
Hi @abc2mit I had originally opened pull request #12, but @Whirlwind noted there was a problem with compatibility on iOS 6, so opened #14 to fix this. I'm not sure why the build is failing through.
Had to revert to 1.2.2 because of the deprecation warning...
after extracting -master.zip , file Base64.h not found. i add this manually from https://github.com/nicklockwood/Base64
Installing with cocoa pods results in a 'Base64.h' file not found as well
Also not here with Cocoa Pods download till now but HEY, nvdcmptr's solution works like a charm!