broccoli-jscs icon indicating copy to clipboard operation
broccoli-jscs copied to clipboard

Use the inline reporter

Open olivierlesnicki opened this issue 9 years ago • 6 comments

Is it possible to use the inline reporter?

olivierlesnicki avatar Jun 15 '15 16:06 olivierlesnicki

please elaborate.

kellyselden avatar Jun 16 '15 15:06 kellyselden

Right now when I add broccoli-jscs I get that kind of error in my console on each build:

Invalid quote mark found at app/utils/utils.js :
    26 |  },
    27 |  deleteCookie: function (name) {
    28 |    document.cookie = name + "=; expires=Thu, 01 Jan 1970 00:00:00 UTC";
-------------------------------------^
    29 |  }
    30 |};

Missing space after line comment at app/views/hub.js :
     4 |
     5 |  didInsertElement: function () {
     6 |    //scroll back to top when we are coming from summary view
------------^
     7 |    Ember.$('html, body').animate({
     8 |      scrollTop: 0


83 code style errors found.

Running manually jscs --reporter inline yields the following results:

app/utils/utils.js: line 28, col 29, Invalid quote mark found
app/views/hub.js: line 6, col 4, Missing space after line comment

More succinct and appropriate for CI

olivierlesnicki avatar Jun 16 '15 16:06 olivierlesnicki

This would require additional code to pass through the option to JSCS. Would appreciate a pull request :)

kellyselden avatar Aug 08 '15 02:08 kellyselden

:+1: for getting this in, I'd like something similar to specify the reporter as junit. @kellyselden - can you provide some guidance on what's the correct spot to pass the option?

et avatar Feb 22 '16 21:02 et

Yea +1 for a testem supported report format, tap, or xunit reporter format.

Using broccoli-jscs alongside testem results in different report output that breaks CIs that are trying to parse output of a certain format.

Ramblurr avatar Jul 13 '16 10:07 Ramblurr

I'm currently swamped by other tasks. This can be implemented the way the other options are passed. PR's welcome.

kellyselden avatar Jul 13 '16 16:07 kellyselden