node-i2c icon indicating copy to clipboard operation
node-i2c copied to clipboard

Make node-i2c compile with Node 4.

Open polaris opened this issue 9 years ago • 6 comments

  • v8::Buffer::New returns an instance of v8::MaybeLocal<>
  • an instance of v8::MaybeLocalv8::Object needs to be asked for the actual local by calling v8::MaybeLocalv8::Object::ToLocalChecked()

polaris avatar Oct 26 '15 10:10 polaris

NaN (https://github.com/nodejs/nan) abstracts such native incompatabilities that are introduced with every new v8 version

seriousManual avatar Nov 23 '15 10:11 seriousManual

+1 to get a working solution merged!

bchr02 avatar Dec 30 '15 14:12 bchr02

Thanks for this pr! Moving forward I'm looking to integrate NaN so these issues don't arise again. Unfortunately, using NaN requires almost a full re-write.

kelly avatar Dec 30 '15 19:12 kelly

@kelly: I would encourage you to merge the PR rather than waiting for the time to do a re-write for NaN. While it is a bit of a hack, when one uses your module because a dependency from npm, it will nearly always break those modules if they are running a currently supported version of node.

saasmath avatar Apr 17 '16 18:04 saasmath

May this change: https://github.com/kelly/node-i2c/pull/96

supersede this PR https://github.com/kelly/node-i2c/pull/70

I didn't check on node-4

rzr avatar Jul 03 '19 06:07 rzr

May you try to submit to this fork: https://github.com/abandonware/node-i2c

rzr avatar Feb 24 '20 10:02 rzr