Kelli Johnson
Kelli Johnson
The [tidyverse style guide](https://design.tidyverse.org/) indicates that [function arguments should not have default values](https://design.tidyverse.org/def-required.html) if they are arguments that **MUST** be supplied by the user. There are many places in r4ss...
https://github.com/r4ss/r4ss/blob/4e2502ca2876350dc87b211855bc611e2818f52b/R/SS_output.R#L1453-L1458 This is failing at the moment for the newest version of SS3 where the data.ss_new file can be saved in the sso folder. I am working on this right...
https://github.com/r4ss/r4ss/blob/928401df8f2bbd8c7b8cfc2071906c31111dddb5/R/SS_fitbiasramp.R#L4 https://github.com/r4ss/r4ss/blob/928401df8f2bbd8c7b8cfc2071906c31111dddb5/R/SSMethod.Cond.TA1.8.R#L72 have urls to dois. While reading through the GitHub action log for a failed attempt to install a branch of {r4ss} I noticed the following message: ``` Found...
During CAPAM 2022 (2022-02-02) @HaikunXu mentioned that it would be nice if the retrospective function could calculate Mohn's rho on an annual basis if quarters are parameterized as years in...
The start of a pull request to standardize getting the version of SS3. Still need to look at the following files: - [ ] SS_output.R - [ ] SS_plots.R -...
While looking at the [available LaTeX symbols](https://mirrors.concertpass.com/tex-archive/info/symbols/comprehensive/symbols-a4.pdf) I noticed that there is an actual symbol for "per thousand", ‰, which looks like a percent sign but it isn't. I would...
https://github.com/r4ss/r4ss/blob/fcacc9a5356c63f679cc17e89fc48f0c5005a25a/R/SSexecutivesummary.r#L297 I am assuming that we could figure it out from `sb.text.name` but I am not entirely sure what the options are. Some of the other captions need units as...
https://github.com/r4ss/r4ss/blob/ad02bd4159fc8e30b55b4d35cac513c1df25e3b8/R/SSplotSPR.R#L55 leads to https://github.com/r4ss/r4ss/blob/ad02bd4159fc8e30b55b4d35cac513c1df25e3b8/R/SSplotSPR.R#L236 and for lingcod the x-axis reads "Relative spawning output: B/B_0" which is actually fraction unfished. I am confused why our default has the term spawning output....
https://github.com/r4ss/r4ss/blob/fcacc9a5356c63f679cc17e89fc48f0c5005a25a/R/SSplotRecdevs.R#L196 Colors (blue and black) are not explained in the figure caption. As well as we could inform readers if the devs were constrained to sum to zero or if...
https://github.com/r4ss/r4ss/blob/5f2dc612a5aa15e0d13f3548ae354bc9a5300db8/R/SSplotIndices.R#L205 In sablefish, we are using a mean centered index of recruitment. This index is not being plotted correctly because some of the values are negative and are being removed...