PSFzf icon indicating copy to clipboard operation
PSFzf copied to clipboard

Chord does not work on VIMode Command

Open belotn opened this issue 2 years ago • 1 comments

All defined chord with Set-PSFzfOption do not work when in vimode "Command". Maybe that's by design ?

belotn avatar Feb 27 '22 13:02 belotn

Can you list recreation steps?

kelleyma49 avatar Mar 28 '22 00:03 kelleyma49

I stumbled upon that issue too. I created a small PR to fix that.

If you are not aware of how you can test that you can do these few steps:

  • Run in pwsh: Set-PSReadLineOption -EditMode Vi
  • Press Escape
  • Try any fzf bounded command

bedware avatar Jun 08 '23 09:06 bedware

@belotn hello 👋 Could you review the changes, please?

bedware avatar Jun 19 '23 18:06 bedware

@bedware , not sure if you saw that @belotn 's PR is merged? Are you still having issues?

kelleyma49 avatar Jun 19 '23 19:06 kelleyma49

@kelleyma49, you confused me and @belotn. I created the PR and ofc I tested my changes. It works. I just want to close the issue and asked the topic starter to test it and give feedback to get enough arguments to close the issue.

bedware avatar Jun 21 '23 19:06 bedware

My apologies for the confusion!

Can we close this out?

kelleyma49 avatar Jun 21 '23 19:06 kelleyma49

It looks like @belotn is not eager to check the fix. I think you can close it. At least I've checked it. After all, the goal is to make them less, not more.

bedware avatar Jun 22 '23 15:06 bedware

Sorry for the delay. I close the case.

belotn avatar Jun 24 '23 06:06 belotn