Ronny Bergmann
Ronny Bergmann
I added all cases (14) above and investigated them * group 1: the signature `solver(M, f, p0::Number)` to write a wrapper for `f` creates an ambiguity with `solver(M, objective, p0)`...
Just fixing `p0` is not enough. But I had an idea, we have `to_mutating_gradient` which I am currently rewriting to do the dispatch on `p` (instead of letting the interface...
I started looking a bit into these points. Ad 1) The function is used when updating the Hessian at https://github.com/JuliaManifolds/Manopt.jl/blob/1856a26d8bce827f7fa97176a9cd1b2effbf0863/src/solvers/quasi_Newton.jl#L677 or https://github.com/JuliaManifolds/Manopt.jl/blob/1856a26d8bce827f7fa97176a9cd1b2effbf0863/src/solvers/quasi_Newton.jl#L738 Ad 2) That might indeed be the case,...
If you see how to correctly add the scaling ( and unifying that to be a real value), feel free to add that as well. I am sure it was...
I think the last point mentioned here should be addressed now in #392, since I removed `stabilize` and introduced `project!`. _edit:_ or to be precise it is described at https://github.com/JuliaManifolds/Manopt.jl/blob/649bc7ebf0c0a3d55c425bd93bc8d722711939dd/Changelog.md?plain=1#L35-L40
I also checked for the scaling, if you compare the part/scale between the backward and forward pass in https://github.com/NicolasBoumal/manopt/blob/3d742b5a4755bb1f256fba1d2dbe6de17b9e5c2f/manopt/solvers/bfgs/rlbfgs.m#L531 the scaling factor should be added in this line https://github.com/JuliaManifolds/Manopt.jl/blob/c8564b847d6cc49bfa675b439d90d24810841d4d/src/plans/quasi_newton_plan.jl#L596 so...
Oh and the full one also has a bool we would change to a real and then scale basically at https://github.com/JuliaManifolds/Manopt.jl/blob/c8564b847d6cc49bfa675b439d90d24810841d4d/src/plans/quasi_newton_plan.jl#L434 as well.
Yes, I can do that tomorrow after my oral exams.