Kelle Cruz

Results 328 comments of Kelle Cruz

It looks good to me! I'm working on writing a test for the read_generic_lightcurve function. Should be done in the next couple of days. The one thing this PR is...

Wow, sorry about that. I confirm that https://zenodo.org/records/1117943 shows up in "My Uploads". What needs to be done?

Should I go through a process for changing ownership of the record?

Oh, I found a new feature where I can share the record with another user! I've just given the Astropy account permission to manage the record. Let's see if that...

## Review checklist for @kelle ### Conflict of interest - [x] As the reviewer I confirm that I have read the [JOSE conflict of interest policy](https://github.com/openjournals/joss/blob/jose/COI.md) and that there are...

I am still a bit confused about why a package is needed if the goal is to teach them "from scratch", but I see the gist of your point. I...

I would also use the HEASARC FITS keywords for lightcurves to improve on the current header template in the primary header template: [data/lc-ext0-header.txt](https://github.com/lightkurve/lightkurve/blob/main/src/lightkurve/data/lc-ext0-header.txt)

Also relevant to #1101 , which is about documentation. I think we should at least be honest about the situation in the documentation and give people a suggestion for what...

I think is fixed by #1144. The new call would be ```Python spec = specutils.Spectrum.read(filepath, flux_col="flux")