node-cron icon indicating copy to clipboard operation
node-cron copied to clipboard

refactor: :recycle: refactor parameters timeZone & utcOffset

Open Victor1890 opened this issue 5 months ago • 1 comments

Description

Refactor runtime check & typings of exclusive parameters timeZone & utcOffset and Add getTimeZoneAndOffset function to utils.ts

Related Issue

Issue #704

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

Victor1890 avatar Jan 23 '24 12:01 Victor1890

Hey @Victor1890, thank you for your contribution!

I'll take the time to review your PR as soon as I can, I'm under a bit of pressure right now.

sheerlox avatar Jan 23 '24 13:01 sheerlox