Jan Winkelmann

Results 45 issues of Jan Winkelmann

In https://github.com/openmls/openmls/pull/1661, the following code stirred some conversation: ```rust impl KeyPackage { /// Get the lifetime of the KeyPackage pub fn life_time(&self) -> &Lifetime { self.payload.leaf_node.life_time().unwrap() } } ``` Specifically,...

bug

This PR adds a new sort of join config to make joining using external commits easier. I believe it's mostly pretty obvious, so just a few things: - The types...

size/m

I added [this test] because I somehow thought the validation check was related to GCEs but then realized it wasn't (only Group Context). I didn't want to remove it, because...

tests

We have built more convenient APIs so writing tests is less painful. Let's make these a bit more polished and let users of the library use them too! Context: https://github.com/openmls/openmls/pull/1599#discussion_r1678860404

For the storage stability KATs a second way to serialize the storage was added. We shouldn't have more than one. Let's choose one for removal and transfer it to the...