XamlX icon indicating copy to clipboard operation
XamlX copied to clipboard

Add GitHub Actions for tests

Open rstm-sf opened this issue 4 years ago • 3 comments

Hello!

Add GitHub Actions for tests

  • [x] Upgrade tfm for core
  • [x] Add actions script
  • [x] Fix tests (in fact they are solved, but they are not solved and these are separate problems #34 )
  • [x] Fix runners tests for net47 on VS

Can also close_ #33

rstm-sf avatar Oct 12 '20 13:10 rstm-sf

* Fix runners tests for `net47` on VS (or separate PR)

This was partially solved.

It turned out that when running the test from studio BaseDirectory from AppDomain.CurrentDomain is equal to this path C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\Extensions\TestPlatform\

For CecilNetstandardTests and CecilTests this can be solved with something like

AppDomain.CurrentDomain.AssemblyResolve += (s, e) =>
{
    var name = e.Name.Split(',').First() + ".dll";
    return Assembly.LoadFile(Path.Combine(selfDir, name));
};

But XamlParserTests depend on this https://github.com/kekekeks/XamlX/blob/697a419675a8055b7ef9a1904360359522b30616/tests/XamlParserTests/CompilerTestBase.cs#L77

or this https://github.com/kekekeks/XamlX/blob/697a419675a8055b7ef9a1904360359522b30616/src/XamlX/IL/SreTypeSystem.cs#L27

which ultimately raises an exception like this https://github.com/kekekeks/XamlX/blob/697a419675a8055b7ef9a1904360359522b30616/src/XamlX/TypeSystem/TypeSystem.cs#L303

rstm-sf avatar Oct 14 '20 19:10 rstm-sf

* Fix tests

This actually works too, but dotnet test doesn't like it https://github.com/rstm-sf/XamlX/pull/3/checks#step:9:22

But it doesn't really work anywhere. I think need to think about it

or this

https://github.com/kekekeks/XamlX/blob/697a419675a8055b7ef9a1904360359522b30616/src/XamlX/IL/SreTypeSystem.cs#L27

rstm-sf avatar Oct 16 '20 17:10 rstm-sf

This actually works too, but dotnet test doesn't like it https://github.com/rstm-sf/XamlX/pull/3/checks#step:9:22

#34

I believe adding the github actions is done. It looks like they are disabled here

rstm-sf avatar Oct 17 '20 14:10 rstm-sf

@kekekeks hello, does it make sense to update it?

rstm-sf avatar Jul 13 '23 17:07 rstm-sf