extensions-source
extensions-source copied to clipboard
Load all chapters for Dynasty Doujins
Checklist:
- [x] Updated
extVersionCode
value inbuild.gradle
for individual extensions - [ ] Updated
overrideVersionCode
orbaseVersionCode
as needed for all multisrc extensions - [x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
- [ ] Added the
isNsfw = true
flag inbuild.gradle
when appropriate - [x] Have not changed source names
- [ ] Have explicitly kept the
id
if a source's name or language were changed - [x] Have tested the modifications by compiling and running the extension through Android Studio
Fixes Dynasty Doujins
only showing the first page of results for Doujin chapters. Some Doujin entries contain multiple pages, which need to be individually parsed (example).
This is a lazy/basic implementation that needs improvement and user quality of life enhancements.
Possible Improvements:
- Currently fetches one page of results at a time. This is slow, especially with only so few chapters per page and some sources listing many tens of pages. A parallel, asynchronous way to fetch chapters would be preferable.
- Chapter list doesn't load until parsing is complete. A major pain considering the previous point.
- Basic method of checking for a successful response and retrying. Some form of backoff would be preferable.
Possible quality of life enhancements:
- Display a Toast whenever a source has over 5 pages of content, then successive Toasts every 5 pages notifying the user of the current page being parsed
- Display a Toast whenever a page needs to be re-requested with number of retries before failure.
As I am reaching the limits of my experience and patience with Kotlin, I will leave these improvements for others to make.
jfyi there are conflicts
jfyi there are conflicts
No idea why there were, but they're resolved now