MangaSwat: re-wrote to match major changes from the source
Checklist:
- [x] Updated
extVersionCodevalue inbuild.gradlefor individual extensions - [x] Updated
overrideVersionCodeorbaseVersionCodeas needed for all multisrc extensions - [x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
- [x] Added the
isNsfw = trueflag inbuild.gradlewhen appropriate - [x] Have not changed source names
- [x] Have explicitly kept the
idif a source's name or language were changed - [x] Have tested the modifications by compiling and running the extension through Android Studio
- [x] Have removed
web_hi_res_512.pngwhen adding a new extension
closes #11398
The Mangaswat source has completely changed their website. This addresses that update to make the extension work again.
@bapeey I think the latest commit should cover everything you suggested. Thank you for the help, let me know if there is anything else needs to be done
@aoitengoku hi thanks for working on this i really appreciate it thank you but the source changed the website again its now "https://meshmanga.com/" can u change it again pls and thank you for ur work
@aoitengoku hi thanks for working on this i really appreciate it thank you but the source changed the website again its now "https://meshmanga.com/" can u change it again pls and thank you for ur work
@SLYVERRR MangaSwat is known to change their domain frequently, if you go to it, you'll see that the website is still using "appswat.com" for the API calls, so I think it's best to leave it as that. It re-directs to the right URL even with the really old "swatscans.com" domain. Let me know if you still think it's an issue :)
@aoitengoku hi thanks for working on this i really appreciate it thank you but the source changed the website again its now "https://meshmanga.com/" can u change it again pls and thank you for ur work
@SLYVERRR MangaSwat is known to change their domain frequently, if you go to it, you'll see that the website is still using "appswat.com" for the API calls, so I think it's best to leave it as that. It re-directs to the right URL even with the really old "swatscans.com" domain. Let me know if you still think it's an issue :)
nope its not a issue then. if it redirects to the right link thank you so much for helping and for fixing the extension i really appreciate it and hopefully they will merge the changes soon thank you again and have a great day :)
Have all open comments been addressed? @aoitengoku Please resolve them as appropriate.
@vetleledaal yes, I set all to resolved.
@vetleledaal @AwkwardPeak7 thank you both for the help and your patience with me. I think the latest commit should resolve everything.
bump
versionIdin class to force users to migrate, as the series urls have changed
Yes, I've already bumped it to force users to migrate in one of the previous commits as bapeey recommended.
In addition to bumping versionId, you should also update this so it doesn't reference MangaThemesia.
Completely forgot about the build file, should be good now