seatest icon indicating copy to clipboard operation
seatest copied to clipboard

Compilation and testing fixes

Open JiaT75 opened this issue 4 years ago • 2 comments

Fixes #22

JiaT75 avatar Nov 12 '21 15:11 JiaT75

Danger. The author of this PR is a known malicious actor.

lewisporter avatar Mar 30 '24 13:03 lewisporter

A couple things catch my eye on this one. First, extern is added to the declaration of seatest_simple_test_result. This may be legitimate, since a much earlier pull request mentions it. However, the liblzma backdoor works by abusing the linker, so I'd make sure anything having to do with linking gets extra scrutiny.

Also, it appears that they modified main to exit successfully where it would have exited unsuccessfully, and vice versa. I don't have background on the project to know if this makes sense or not.

ZLima12 avatar Mar 31 '24 20:03 ZLima12