jekyll-target-blank icon indicating copy to clipboard operation
jekyll-target-blank copied to clipboard
verified publisher icon keithmifsud

Corrected wrong example

Open xplosionmind opened this issue 4 years ago • 4 comments

The second example about adding custom rels was identical to the former, while another attribute should have been added.

xplosionmind avatar Mar 19 '21 09:03 xplosionmind

@xplosionmind can you fix the checks issues, please?If so, I'll add it to v2,1

keithmifsud avatar Mar 23 '21 15:03 keithmifsud

can you fix the checks issues, please?

Sorry, honestly, I have no idea how to understand the error, its source and how to fix it. I forked the repository and simply changed the README.

I never stumbled upon Travis-CI before and it is the first time I have a PR fail. Could you give me some insights?
Thank you very much ❤️

xplosionmind avatar Mar 24 '21 11:03 xplosionmind

Hi @xplosionmind ... I think you can just ignore these files:

Rubocop 0.71.0
vendor/bundle/ruby/2.5.0/gems/jekyll-4.2.0/.rubocop.yml: Layout/LineLength has the wrong namespace - should be Metrics
vendor/bundle/ruby/2.5.0/gems/jekyll-4.2.0/.rubocop.yml: Lint/SelfAssignment has the wrong namespace - should be Style
Configuration file not found: /home/travis/build/keithmifsud/jekyll-target-blank/vendor/bundle/ruby/2.5.0/gems/jekyll-4.2.0/.rubocop_todo.yml
The command "scripts/cibuild" exited with 2.

from rubocop because they're bundles and outside our codebase.

https://docs.rubocop.org/rubocop/configuration.html#includingexcluding-files

keithmifsud avatar Nov 01 '21 02:11 keithmifsud

I think this is jekyll-target-blank's bug. We're using version 0.71.0 of Rubocop where the latest version is 1.26. Furthermore, Metrics/LineLength was moved to Layout/LineLength in Rubocop version 0.78.0

prplecake avatar Mar 11 '22 15:03 prplecake