Keith Mattix II comments

Results 442 comments of


                                            Keith Mattix II

@dgn Good call on istio/enhancements; I honestly forgot it existed. I'll try to finish up discussion in this PR and then move this over; sound good?

Closing in favor of https://github.com/istio/enhancements/pull/198. Thank you for your comments!

Not stale

/ok-to-test

Good catch; you're right. This filter is filtering the CRDs not the CRs

At what point do we want to close this?

Have we considered explicitly marking this feature beta so it doesn't sort of sneak into the GA scope?

FWIW, I tried to fix the schema in #57426, but to no avail. I believe the new library has a bug

Thanks for the PR! I added a comment about some previous attempts: https://github.com/istio/istio/pull/57445#issuecomment-3212284177

Yes, from our testing, the issue appears to be fixed