Keith Mattix II

Results 443 comments of Keith Mattix II

Looks like a flake in the udp tests? /retest envoy-presubmit /retest envoy-presubmit (Checks (Linux x64) Linux x64 compile_time_options)

@cpakulski @adisuissa thanks for your patience on this review; still learning the ins and outs of the devtools. Formatting and tests should be good to go now!

> @keithmattix I think you should also update changelogs/current.yaml. Does it need to be something different than what I have [here](https://github.com/envoyproxy/envoy/pull/33857/files#diff-6f9c718224c533c13c2c0ba1d5abaab86be9d0cc73808749c77934e9f9b0d5d0L158)?

No worries @zuercher - it should be caught up now

/retest envoy-presubmit /retest envoy-presubmit (Linux arm64 Build and test)

FYI we found a way around this and don't need to backport

I completely lost track of this; thanks for the ping

I can actually no longer reproduce this on master; closing

Yeah I'll take a look. I wonder if I can /assign