omnibear icon indicating copy to clipboard operation
omnibear copied to clipboard

clear localStorage syndicateTo on logout.

Open dougbeal opened this issue 5 years ago • 6 comments

Fixes#84

dougbeal avatar Mar 10 '19 00:03 dougbeal

Confirmed fix by

  1. Omnibear log into https://dougbeal.com with Bridgy Publish plugin activbe
  2. Omnibear log out
  3. disable Bridgy Publish
  4. Omnibear log in
  5. Successful bridgy github syndication

(Originally published at: https://crw.moe/t/1ge)

dougbeal avatar Mar 10 '19 01:03 dougbeal

This should work now, but getting an error:

Context https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map page.js:5013 (anonymous function)

_browser2.default.runtime.sendMessage({ action: ‘focus-window’, payload: { pageEntry: pageEntry, selectedEntry: selectedEntry } });

Several localStorage fail to remove

(Originally published at: https://crw.moe/t/1gw)

dougbeal avatar Mar 10 '19 03:03 dougbeal

These localStorage items don’t get cleared

‘authEndpoint’,* ‘tokenEndpoint’,*

‘syndicateTo’,*

(Originally published at: https://crw.moe/t/1gx)

dougbeal avatar Mar 10 '19 03:03 dougbeal

Thanks for taking a look at this! Your change should work. I'll see if I can reproduce that error when I get the time.

keithjgrant avatar Mar 25 '19 12:03 keithjgrant

I just noticed the date on this 😖. Sorry for the delay!

keithjgrant avatar Mar 25 '19 12:03 keithjgrant

Also just chiming in since I saw the notifications, and I may have mentioned this elsewhere, but you're not really meant to use local storage with extensions.

There is an api for storing data with extensions: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage

grantcodes avatar Mar 25 '19 12:03 grantcodes