Keith W. Campbell

I think the result looks good, but I suggest this should be squashed; we don't need commits that include incomplete conflict resolution, like https://github.com/eclipse-openj9/openj9/commit/2f9d1d21e6413ea993f8eadf8af4e146b31fd757 which add this to `j9jvmti.tdf`, `vm_api.h`,...

Please reformat the commit message to avoid overly long lines; see https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines for guidance.

Jenkins test sanity alinux jdk21

Have you tested with gcc 13 (which is the default version on Ubuntu 24.04)?

I saw (1) in my xlinux build with gcc 13; that one will require some more thought. Warnings (2) and (4) should be easy to address: simply remove the dead...

> Do you know how it's possible for a change in the JIT's `CMakeLists.txt` to be affecting non-JIT code? The only thing that I can think of is that `OMR_WARNINGS_AS_ERRORS`...

> I hadn't actually tested this at the time, but it turns out that even the warning from the openjdk code is treated as an error. Would that be a...

Jenkins test sanity plinux jdk23

The test failure appears to be https://github.com/eclipse-openj9/openj9/issues/17474.

Is the plan that the changes above will be reverted when we have the solution anticipated in https://github.com/ibmruntimes/openj9-openjdk-jdk/pull/759#discussion_r1537643091?