Keith Cirkel

You can attach data to the `Error` class: ```js const reason = new Error('User clicked Kill Now') reason.force = true function aborted (event) { if (event.target.reason.force) { kill() } else...

Instead of setting the value inside the node, I refactored it to use a `useEffect` and set the actual DOM nodes `.value`. The bug seems to not be present in...

Sounds great! PRs welcome!

> ```ruby > > Please update your billing information in order to add a payment method. > > ``` This seems like a better idea to me. With an `IntersectionObserver`...

A quick search across the codebase says no, I can’t see any instances that do this in dotcom or education.

Pebble size. I'll look closely tomorrow and if I can, I'll raise a fix.

If you're using the JS API the call has changed from `.show()` to [`.showModal()`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/showModal), as it is now using the native `` element which has both. The `with_show_button` has changed...

> Would the team be open to a PR that makes it possible to skip/cancel the initial fetch? Yep sounds like a great addition :+1: > 1. Should load fire...

Other elements we have assign a `fetch` function to themselves which allows for monkey patching ([for example ``](https://github.com/github/include-fragment-element/blob/2d85b9f9f6ab1d676d4261f212666ad86c01135b/src/index.ts#L124-L126)). I'm not fully convinced about the pattern, however. I think having `loadstart`...

> @keithamus does your firefox patch also do fullscreen or just dialogs? https://phabricator.services.mozilla.com/D200686 Just dialogs. Want me to raise one for fullscreen too?