Keith Smiley

icon indicating a website link https://smileykeith.com icon indicating an email [email protected]

icon company @ModularML icon location Seattle, WA icon location devx @modularml, maintainer of bazel's iOS support, creator of the Mobile Native Foundation, LLVM & Swift contributor, previously Principal Engineer at Lyft

Results 1356 comments of Keith Smiley

Package.swift: adds dynamic library

Thanks! Can you add a description for the use case and the DCO here

Data race in static Kronos.Clock.annotatedNow.getter

So technically right now we expect you to call `.now` and `.sync` from the same thread. In our app we only ever call this from the main thread. I think...

Support for dylib for SPM?

@bogdan-razvan if you can submit a PR adding this I'll merge it!

How to handle keys with "."

There isn't curreny a way to do this. I'm not sure what the best way to add this would be. Maybe by first checking if the key exists and then...

How to handle keys with "."

That wouldn't be ideal but it's worth a try. I'm not sure if our string splitting logic would catch that. -- Keith Smiley > On Jan 7, 2019, at 08:09,...

Bitbucket Support

Right now the only "reporter" is GitHub. If you'd like to submit bitbucket support you'd need to duplicate the general logic there on bitbucket's API

Allow to change max github reports on command line

This LGTM, can you rebase it @twidi and let me know when you do so I can merge?

Apple Watch support

Feel free to submit a PR here!

Change NSArray and NSDictionary to use Swift literal dictionary and array

So master has been updated Xcode wise. I'm still a bit worried about the performance implications here still 😞 but testing that part will definitely be a pain

Sort messages added to Github for check consistency

This LGTM, can you rebase it @twidi and let me know when you do so I can merge?