Keith Smiley

Results 1359 comments of Keith Smiley

If you select the default in the Xcode preferences GUI you can make sure it's normalized. Or `xcode-select --reset` I'm using 12.5.1

Looks like you might want to rebase and investigate the test failures, they don't look like flakes

I assumed this was separate (you'll need to rebase again since this repo has the setting to force you to be up to date enabled)

LGTM but @sergiocampama or @thomasvl will have to review

I have access to merge this now, so if you'd like to rebase this now i'd be happy to

This is an interesting bug. Thanks for the awesome repro case, without that I definitely wouldn't have looked into this. So the core problem is this limitation of the linker...

I would expect setting `alwayslink = True` on the swift_library would correctly propagate to the ios_framework