Keith Turner

I like ScanServerSelector also as a name. I do think it would be good to have something besides Dispatcher in the name to avoid confusion w/ the server side plugin.

Sure @Jman24 . Let me know if you have any questions.

> Read the comment above the call to exists(). It explains why it is doing this. Good catch, I think I wrote that comment a very long time ago. Thinking...

> Should it just be left as is then? I did a quick survey of the code to see how Accumulo is using node data from zoocache. I found the...

@mjwall I pulled these changes locally and experimented with writing the following unit test and it passed. ```java @Test public void testMissingTableIds() throws Exception { GarbageCollectionAlgorithm gca = new GarbageCollectionAlgorithm();...

@mjwall thinking about unit testing the cases where table ids changes during scanning the refs. Maybe we could simulate this by making TestGCE.getReferenceIterator() change the tableid set.

> I am worried my assumptions are wrong here, but assuming they are correct the logic in ensureAllTablesChecked is this. The logic in ensureAllTablesChecked looks great and I really like...

> I considered adding some functions to TestGCE but then pulled out the logic to one method. I was hoping it would be enough to just test that method with...

> But thinking about it further, I realize you might be getting at this. For whatever reason, something unexpected happened during our scan of the metadata table. Therefore, we should...

This issue was opened based on discussion on #2492