Keith Hall

Results 465 comments of Keith Hall

I have moved it to a new `syntax_tests` module and added a doc comment :+1: The main function *has* been modified; it used to read line by line, parsing as...

Printed text isn't the *only* output - the API returns the successful/failed assertion count too ;) I would guess that changing the API to return structs with the information about...

I think that returning an iterator with the results is a cool idea, it would allow a consumer of the API to fail fast when a failure occurs, if so...

No worries, the work you did on the color schemes was awesome and indeed more important ;)

although not mentioned in the original post, the idea behind moving the code from an example to be part of the public API is because running syntax tests isn't just...

I guess the fundamental flaw with rewriting `embed` actions to the "equivalent" `with_prototype` construct is that `embed` is guaranteed to escape at the `escape` pattern, but with `with_prototype`, a match...

Just a note for when we work on this, there is an [open question for SublimeHQ to answer](https://github.com/SublimeTextIssues/Core/issues/2342#issuecomment-440943499) regarding whether the `prototype` context should be ignored in contexts `embed`ded from...

yes, that makes sense, and sounds like the way forward. For multiple embeds, I believe the same ordering as `with_prototype` is used - the embedded contexts are prioritized by the...

nice :+1: one other thing I wanted to check was how escapes are handled if one escape pattern matches inside another one... say, `escape: me` and `escape: test-me` with text...

In case it helps, I cut down the C# syntax definition into what I believe is (almost) the smallest necessary for correct scoping of the test, and the panic *didn't*...