e3fp icon indicating copy to clipboard operation
e3fp copied to clipboard

Float instead of integers in n_confs

Open j-adamczyk opened this issue 1 year ago • 1 comments

The expression:

n_confs = self.max_conformers * self.pool_multiplier

can result in float number. AllChem.EmbedMultipleConfs will then throw an error, since it expects integers for numConfs and maxAttempts. This should be rounded to the nearest integer.

j-adamczyk avatar Apr 10 '24 12:04 j-adamczyk

Nice catch, the relevant line is https://github.com/keiserlab/e3fp/blob/fdf1417107803eb1453181dda56d8e7888affaa1/e3fp/conformer/generator.py#L217. In e3fp.conformer.generate, pool_multiplier is documented to be an integer, but we don't enforce this. Probably the better approach is to throw an error if the user provides a non-integer float.

sethaxen avatar Apr 18 '24 13:04 sethaxen