upgrade-manager
upgrade-manager copied to clipboard
Add missing ec2:DescribeLaunchTemplates permission
This goes part way to fixing #194
Codecov Report
Merging #200 (1d5ce44) into master (4da0472) will decrease coverage by
0.54%
. The diff coverage isn/a
.
:exclamation: Current head 1d5ce44 differs from pull request most recent head 3d7af89. Consider uploading reports for the commit 3d7af89 to get more accurate results
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 69.48% 68.93% -0.55%
==========================================
Files 12 11 -1
Lines 1088 940 -148
==========================================
- Hits 756 648 -108
+ Misses 294 260 -34
+ Partials 38 32 -6
Flag | Coverage Δ | |
---|---|---|
unittests | 68.93% <ø> (-0.55%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
api/v1alpha1/rollingupgrade_types.go | 66.66% <0.00%> (-31.64%) |
:arrow_down: |
controllers/rollingupgrade_controller.go | 68.62% <0.00%> (-1.17%) |
:arrow_down: |
controllers/helpers.go | 98.41% <0.00%> (ø) |
|
api/v1alpha1/zz_generated.deepcopy.go | 0.00% <0.00%> (ø) |
|
controllers/common/metrics.go |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4da0472...3d7af89. Read the comment docs.
Looks like this cannot be rebased, @bodgit can you resend this PR?
ec2:DescribeLaunchTemplateVersions
also seems to be missing.