kube-forensics icon indicating copy to clipboard operation
kube-forensics copied to clipboard

Published 20 hours ago • verified publisher icon keikoproj

Create worker subdirectory for worker docker image

Open tekenstam opened this issue 5 years ago • 4 comments

Is this a BUG REPORT or FEATURE REQUEST?: FEATURE

What happened: Currently there are multiple docker files in the root of the repo. This may be confusing for which docker file creates which image.

What you expected to happen:

  1. Create new worker subdir
    • Move Dockerfile.worker and script for the worker image to this directory
  2. Move Dockerfile to the controllers subdirectory
  3. Update Makefile to reflect these changes

tekenstam avatar Aug 15 '19 00:08 tekenstam

I'll take this.

z0rx0r avatar Sep 28 '19 04:09 z0rx0r

➜ kube-forensics git:(feature/docker-subdir) git push origin feature/docker-subdir ERROR: Permission to keikoproj/kube-forensics.git denied to z0rx0r. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

z0rx0r avatar Oct 01 '19 22:10 z0rx0r

@z0rx0r Please fork this repo and submit your PR per our contribution guidelines.

https://github.com/keikoproj/kube-forensics/blob/master/.github/CONTRIBUTING.md

tekenstam avatar Oct 02 '19 04:10 tekenstam

Sorry, I had to delete PR #14. It was committed with the wrong name and I couldn't pass the cla check.

AnShafs avatar Oct 09 '19 05:10 AnShafs