governor icon indicating copy to clipboard operation
governor copied to clipboard

Published 20 hours ago • verified publisher icon keikoproj

Increase test coverage

Open eytan-avisror opened this issue 5 years ago • 4 comments

unit-test coverage is around 50%, should get it >75% at the very least.

eytan-avisror avatar Aug 12 '19 00:08 eytan-avisror

Can I take this up?

pratyushprakash avatar Oct 08 '19 14:10 pratyushprakash

Hi @pratyushprakash Thanks for your interest in this, I am afraid we should probably do #14 before doing this as it will probably break some tests.

If you'd like we are happy to take such changes in tests for pod-reaper which is not expecting any refactor soon, however for node-reaper we should probably wait until #14 is done - I was planning on working on it soon.

eytan-avisror avatar Oct 08 '19 17:10 eytan-avisror

@eytan-avisror How about a PR for just the pod-reaper? I can help out in #14 too if you want.

pratyushprakash avatar Oct 09 '19 05:10 pratyushprakash

Thanks @pratyushprakash feel free to send a PR with unit test improvements for pod-reaper. As for #14 I've already started working on it, I'll send a PR in a few days and we'll see if there is more help needed there.

One issue that may be interesting and we really need is #7 - would be awesome if you can make any contributions there! take a look - we can discuss further on that issue if you find it interesting.

eytan-avisror avatar Oct 09 '19 07:10 eytan-avisror