governor icon indicating copy to clipboard operation
governor copied to clipboard

Published 20 hours ago • verified publisher icon keikoproj

Node Reaper: Refactor

Open eytan-avisror opened this issue 5 years ago • 2 comments

We need to refactor node reaper, it started as a simple script, but as we add more and more logic, it seems the current structure is becoming a bit flakey.

We should have a make some structural improvements.

  • K8s/AWS clients should be instantiated outside, this will allow to unit tests Run()
  • Better data structures for for reapable/drainable
  • Remove duplicate code
  • A lot of unnecessary if conditions
  • Pass arguments to ReaperContext and validate them in a cleaner way

eytan-avisror avatar Sep 21 '19 22:09 eytan-avisror

can i work on this? @eytan-avisror

aakashchan avatar Apr 24 '20 07:04 aakashchan

@chan24 Sure, but can you please keep PRs small (vs. very large refactor PRs) so we can review/merge easily?

eytan-avisror avatar Apr 24 '20 20:04 eytan-avisror