addon-manager icon indicating copy to clipboard operation
addon-manager copied to clipboard

Workflow Resource Template

Open VaibhavPage opened this issue 5 years ago • 2 comments

Is this a BUG REPORT or FEATURE REQUEST?: FEATURE REQUEST

What happened: The Addon CR expects the Workflow template to be a string which leads to unnecessary confusion because it is difficult to debug issues related to resource indentation in the YAML string.

What you expected to happen: Provide an option to define actual Workflow resource using unstructured.Unstructured.

Anything else we need to know?: I have already done a similar feature in Argo-Events https://github.com/argoproj/argo-events/blob/master/pkg/apis/sensor/v1alpha1/types.go#L568

VaibhavPage avatar Jan 24 '20 17:01 VaibhavPage

@kevdowney I can add this feature if you are fine with it

VaibhavPage avatar Jan 24 '20 17:01 VaibhavPage

@VaibhavPage Yes, please do add this, would be a great improvement!

kevdowney avatar Jan 24 '20 17:01 kevdowney