Regression in 1.0.34

[ABAG603]

Hi,

there is regression related to the theming introduced in v1.0.34. I have BgColor set to #1e1e2e in my config but background is being reset to #282828. Before that version it was picked up correctly. My full config is:

colors:
  BgColor: "#1e1e2e" 
  FgColor: "#cdd6f4"
  BorderColor: "#585b70"
  Black: "#45475a"
  Red: "#f38ba8"
  Green: "#a6e3a1"
  Yellow: "#f9e2af"
  Blue: "#89b4fa"
  Magenta: "#f5c2e7"
  Cyan: "#94e2d5"
  Gray: "#9399b2"

[keidarcy]

Hi, I'd like to help but I can't reproduce that. It works fine in my environment. Can you paste your full config file and command?

[ABAG603]

My full config is in first message. Running e1s with just

e1s

[keidarcy]

@ABAG603 Hi, with the latest version you can find colors in debug message.

2024-05-21T09:57:01+09:00 DBG color/colors.go:73 colors colors="{BgColor:#282828 FgColor:#ebdbb2 BorderColor:#8ec07c Black:#282828 Yellow:#d79921 Green:#98971a Red:#cc241d Blue:#458588 Magenta:#b16286 Cyan:#689d6a Gray:#808080}"

[ABAG603]

@keidarcy the colors in the log match the values I have in config but background isn't rendered correctly.

As I said, it was working correctly up untill version 1.0.34

[keidarcy]

the colors in the log match the values

In that case, not something I can help. Depends on your environment(terminal emulator, os etc..). I tested multiple devices and multiple configurations working fine. Recommend test --theme or colors.BgColor: black

[ABAG603]

Wait a sec. My environment didn't change between 1.0.33 and 1.0.34 - only thing that have changed is e1s. With all respect, this is not how you close issues. Anyway, if you're not willing to drill down and find the root cause can you at least push 1.0.34 to homebrew, so I can easily rollback?

[ABAG603]

@keidarcy so, even though my config didn't change when I've started to get this issue, I've managed now to fix this whole thing by adjusting my tmux config.